Enable v0.1 std-trait workaround for additional targets#169
Merged
newpavlov merged 6 commits intorust-random:0.1from Dec 7, 2020
Merged
Enable v0.1 std-trait workaround for additional targets#169newpavlov merged 6 commits intorust-random:0.1from
newpavlov merged 6 commits intorust-random:0.1from
Conversation
This makes it easier to see what targets use which internal modules. It also makes our std-traits workaround more clear. Signed-off-by: Joe Richey <joerichey@google.com>
From `v0.1.0` to `v0.1.6` we had this enabled for windows/unix, and we inadvertantly removed it. Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Member
Author
|
@pie-flavor can you verify that this fixes your problem. |
newpavlov
approved these changes
Nov 12, 2020
Member
|
Though I do not understand why the UWP build fails in the CI job. UPD: It looks like for some reason among UWP targets only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168
The first commit cleans up how we handle our various helper modules (similar to what we did for
v0.2), but does not make any functional changes.The second commit enables our
std::error::Errorimplementations forwindows,target_os = "fuchsia",target_os = "ios". These are the additionalwindowsandunixtargets we supported inv0.1.6. We don't enable the workaround fortarget_arch = "wasm32"as that would be a breaking change (from newer version) forno_stdwasm32targets.Here is a history of when we've enabled
std::error::Errorimplementations:v0.1.0-v0.1.6:stdfeature on most targetsv0.1.7-v0.1.8:unixtargets that neededutil_libcv0.1.9-v0.1.10:"std"featurev0.1.11 - v0.1.15v0.1.9changes (as they were a breaking change)